Implement step sourcemaps #310
Draft
+1,411
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8fd157d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
pranaygp
requested review from
TooTallNate
and removed request for
TooTallNate and
adriandlam
adriandlam
force-pushed
the
pranaygp/normalize-workbenches
branch
2 times, most recently
from
d9e08f0 to
b0ad30f
Compare
pranaygp
force-pushed
the
pranaygp/11-12-implement_step_sourcemaps
branch
from
8e19f6a to
97a8268
Compare
Normalize trigger scripts across workbenches fix: include hono in local build test test: include src dir for test test: add workflow dir config in test to fix sveltekit dev tests add temp 7_full in example wokrflow format fix(sveltekit): detecting workflow folders and customizable dir Remove 7_full and 1_simple error replace API symlink in webpack workbench Fix sveltekit and vite tests Fix sveltekit symlinks Test fixes Fix sveltekit workflows path Dont symlink routes in vite Include e2e tests for hono and vite fix error tests post normalization wip - attempted fixes
* Proper stacktrace propogation in world Proper stacktrace propogation in world * Standardize the error type in the world spec * Normalize Workbenches Normalize trigger scripts across workbenches fix: include hono in local build test test: include src dir for test test: add workflow dir config in test to fix sveltekit dev tests add temp 7_full in example wokrflow format fix(sveltekit): detecting workflow folders and customizable dir Remove 7_full and 1_simple error replace API symlink in webpack workbench Fix sveltekit and vite tests Fix sveltekit symlinks Test fixes Fix sveltekit workflows path Dont symlink routes in vite Include e2e tests for hono and vite * fix error tests post normalization * fix(sveltekit): reading file on hmr delete * changeset * fix(vite): add resolve symlink script * fix(vite): missing building on hmr * test local builder in vite * test: increase timeout on hookWorkflow * test: ignore vite based apps in crossFileWorkflow * test: fix nitro based apps status codes * fix: intercept default vite spa handler on 404 workflow routes * fix: vite hook route returning 422 * test: use 422 for hookWorkflow expected * test: fix hono returning 404 * chore: add comment to middleware to clarify * make api route for duplicate case * revert * revert: nitro builder * add back nitro unhandled rejection logic * test: add hono * changeset * fix: unused method * fix: remove duplicate import * remove * chore: add comments to clarify * test remove vite symlink script --------- Co-authored-by: Pranay Prakash <[email protected]>
pranaygp
force-pushed
the
pranaygp/normalize-workbenches
branch
from
b0ad30f to
b2c6e3b
Compare
pranaygp
force-pushed
the
pranaygp/11-12-implement_step_sourcemaps
branch
from
97a8268 to
8fd157d
Compare
adriandlam
force-pushed
the
pranaygp/normalize-workbenches
branch
2 times, most recently
from
09a60f6 to
e28cfa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===
Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)
↓
workflowErrorHelper (98_workflow_error_test.ts:7)
↓
crossFileErrorWorkflow (99_e2e.ts:290)
=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===
Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)
↓
stepErrorHelper (98_step_error_test.ts:10)
↓
deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]
↓
[Error preserved and propagated to workflow context]
=== KEY OBSERVATIONS ===